Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail fast for minimal-versions check #40

Closed
joshka opened this issue Apr 1, 2024 · 3 comments
Closed

Fail fast for minimal-versions check #40

joshka opened this issue Apr 1, 2024 · 3 comments

Comments

@joshka
Copy link

joshka commented Apr 1, 2024

In RustCrypto/elliptic-curves#1039 (comment) we noted that the use of hack to test combinations can be overkill (and take a long time when there are lots of combinations - some combinations were as long as 15-30 minutes).

As an optimization, perhaps adding cargo test --all-features as an initial step to the workflow would be the right thing to do. If that fails, there there's enough information to get started on fixing the problem and running cargo-hack won't be all that helpful.

@newpavlov
Copy link
Member

newpavlov commented Apr 1, 2024

Note that you already can overwrite the default command by providing the stable-cmd variable. Adding cargo test --all-features by default could be a good addition though.

@joshka
Copy link
Author

joshka commented Apr 1, 2024

Good idea to push this upstream!

@newpavlov
Copy link
Member

This will be fixed by cargo hack in a future release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants