Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start --feature-powerset with --all-features #246

Closed
newpavlov opened this issue Apr 1, 2024 · 2 comments · Fixed by #247
Closed

Start --feature-powerset with --all-features #246

newpavlov opened this issue Apr 1, 2024 · 2 comments · Fixed by #247
Labels
A-features Area: features (--feature-powerset, --each-feature, etc.)

Comments

@newpavlov
Copy link

When used as part of CI it's beneficial for cargo hack to fail early. If crate has a failing feature, then tests are likely to fail on cargo test --all-features, so it arguably makes sense for cargo hack to start with it and only after it has succeeded to continue check other feature combinations. If --exclude-features is used, then we should start with the biggest number of allowed features.

Relevant issue: RustCrypto/actions#40
@taiki-e taiki-e mentioned this issue Apr 2, 2024
Merged
@taiki-e
Copy link
Owner

taiki-e commented Apr 2, 2024

Opened #247 to implement this.

@taiki-e taiki-e added the A-features Area: features (--feature-powerset, --each-feature, etc.) label Apr 2, 2024
@taiki-e
Copy link
Owner

taiki-e commented Apr 2, 2024

Implemented in 0.6.27 (#247).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-features Area: features (--feature-powerset, --each-feature, etc.)
Projects
None yet
Milestone
No milestone
2 participants
@newpavlov @taiki-e