Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrating to inline assembly (Rust 1.59) #45

Open
tarcieri opened this issue Feb 11, 2022 · 2 comments
Open

Migrating to inline assembly (Rust 1.59) #45

tarcieri opened this issue Feb 11, 2022 · 2 comments

Comments

@tarcieri
Copy link
Member

With the forthcoming release of Rust 1.59 at the end of February, which stabilizes inline assembly, I think it's time to start planning on eventually retiring this repo and migrating to inline assembly instead.

This should simplify a number of things like linking, testing, and overall crate/repo structure.

@roblabla
Copy link

roblabla commented Sep 9, 2022

Would you accept a PR adding a feature enabling inline asm? The use-case is that I'm cross-compiling stuff, and having a working assembler for some of the platforms I target is painful. Using rustc's built-in support for assembly would mean less moving parts for me.

@newpavlov
Copy link
Member

Yes, but the PR would have to be opened against the hashes repository, not this one. To prevent breakage, inline assembly impl should be behind its own feature (e.g. inline-asm) until the next breaking release.

tarcieri added a commit that referenced this issue Jan 16, 2023
Going forward, ASM should be added directly to the relevant hashes crates using
inline assembly as stabilized in Rust 1.59.

See #45
tarcieri added a commit that referenced this issue Jan 16, 2023
Going forward, ASM should be added directly to the relevant hashes crates using
inline assembly as stabilized in Rust 1.59.

See #45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants