aes: remove Copy from public types of "soft" impls #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using the `autodetect` module, we store the possible backing AES implementations in a `union`, which presently requires all fields be `Copy` until `ManuallyDrop` stabilizes in Rust 1.49. However, the "soft" types are directly exposed on non-x86 architectures or when the `force-soft` feature is enabled. Having these types be `Copy` when the autodetect wrappers aren't is inconsistent, and it's better to require an explicit clone for these to make users think when they make copies of material. As a workaround until `ManuallyDrop` lands, this gates the `Copy` impl on the "soft" types to only cases where it is hidden behind the autodetect facade (i.e. when they presently *need* to be `Copy`).
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the
autodetectmodule, we store the possible backing AES implementations in aunion, which presently requires all fields beCopyuntilManuallyDropstabilizes in Rust 1.49.However, the "soft" types are directly exposed on non-x86 architectures or when the
force-softfeature is enabled. Having these types beCopywhen the autodetect wrappers aren't is inconsistent, and it's better to require an explicit clone for these to make users think when they make copies of key material.As a workaround until
ManuallyDroplands, this gates theCopyimpl on the "soft" types to only cases where it is hidden behind the autodetect facade (i.e. when they presently need to beCopy).