-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
p256/k256: prep for 2.0 release #25
Conversation
4fe50a5
to
5bfc537
Compare
- Make `Scalar` types a `pub` export - Adds docs.rs config for `arithmetic` feature gating - Remove obsolete comments about arithmetic status - Remove broken deps.rs badge - Fix MSRV in docs
5bfc537
to
6fa5afa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. 🐧
//! # Status | ||
//! | ||
//! Currently, no actual group operations are implemented. Only point compression and | ||
//! decompression is supported. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@@ -12,6 +7,8 @@ mod util; | |||
#[cfg(any(feature = "test-vectors", test))] | |||
pub mod test_vectors; | |||
|
|||
pub use self::scalar::Scalar; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@@ -16,6 +7,8 @@ mod util; | |||
#[cfg(any(feature = "test-vectors", test))] | |||
pub mod test_vectors; | |||
|
|||
pub use self::scalar::Scalar; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Will go ahead and merge this, but wait a day to do a crate release if anyone has any follow-up comments. |
Scalar
types apub
exportarithmetic
feature gating