Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p256/k256: prep for 2.0 release #25

Merged
merged 1 commit into from
Apr 29, 2020
Merged

p256/k256: prep for 2.0 release #25

merged 1 commit into from
Apr 29, 2020

Conversation

tarcieri
Copy link
Member

@tarcieri tarcieri commented Apr 29, 2020

  • Make Scalar types a pub export
  • Adds docs.rs config for arithmetic feature gating
  • Remove obsolete comments about arithmetic status
  • Remove broken deps.rs badge
  • Update MSRV to 1.37

@tarcieri tarcieri requested review from tuxxy and str4d April 29, 2020 17:20
@tarcieri tarcieri force-pushed the v0.2-release-prep branch 2 times, most recently from 4fe50a5 to 5bfc537 Compare April 29, 2020 17:34
- Make `Scalar` types a `pub` export
- Adds docs.rs config for `arithmetic` feature gating
- Remove obsolete comments about arithmetic status
- Remove broken deps.rs badge
- Fix MSRV in docs
Copy link
Contributor

@tuxxy tuxxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. 🐧

//! # Status
//!
//! Currently, no actual group operations are implemented. Only point compression and
//! decompression is supported.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@@ -12,6 +7,8 @@ mod util;
#[cfg(any(feature = "test-vectors", test))]
pub mod test_vectors;

pub use self::scalar::Scalar;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@@ -16,6 +7,8 @@ mod util;
#[cfg(any(feature = "test-vectors", test))]
pub mod test_vectors;

pub use self::scalar::Scalar;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tarcieri
Copy link
Member Author

Will go ahead and merge this, but wait a day to do a crate release if anyone has any follow-up comments.

@tarcieri tarcieri merged commit b7d5b9a into master Apr 29, 2020
@tarcieri tarcieri deleted the v0.2-release-prep branch April 29, 2020 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants