p384: criterion benchmarks #588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'd like to use these to measure performance changes if the `fiat-crypto` field implementations are converted to `const fn`, specifically leveraging criterion's support to track percentages by which performance has increased/decreased. Adapted from the benchmarks in the `k256` crate.
tarcieri
force-pushed
the
p384/criterion-benchmarks
branch
from
81ea0ae
to
c50eabd
Compare
tarcieri
added a commit
that referenced
this pull request
Jun 9, 2022
Adapts the benchmarks added in the `p384` crate in #588 to the `p256` crate, with the goal of using them to measure the performance impact of switching to fiat-crypto's arithmetic implementations.
tarcieri
added a commit
that referenced
this pull request
Jun 9, 2022
Adapts the benchmarks added in the `p384` crate in #588 to the `p256` crate, with the goal of using them to measure the performance impact of switching to fiat-crypto's arithmetic implementations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to use these to measure performance changes if the
fiat-cryptofield implementations are converted toconst fn,specifically leveraging criterion's support to track percentages by which performance has increased/decreased.
Adapted from the benchmarks in the
k256crate.