p384: make core field ops const fn
#590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that #589 is landed, it's possible to add `const fn` implementations of all core field operations, including conersions to/from Montgomery form as well as arithmetic operations: add, double, sub, mul, neg, square
tarcieri
added a commit
that referenced
this pull request
Jun 3, 2022
Now that conversions to/from the Montgomery domain are `const fn` (#590) it's possible to define constants in their canonical form, rather than converting them into the Montgomery domain first. This makes the code clearer and easier to audit.
tarcieri
added a commit
that referenced
this pull request
Jun 3, 2022
Now that conversions to/from the Montgomery domain are `const fn` (#590) it's possible to define constants in their canonical form, rather than converting them into the Montgomery domain first. This makes the code clearer and easier to audit.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that #589 is landed, it's possible to add
const fnimplementations of all core field operations, including conersions to/from Montgomery form as well as arithmetic operations: add, double, sub, mul, neg, square