Skip to content

Commit

Permalink
pem-rfc7468+spki: relax base64ct requirements to ^1 (#239)
Browse files Browse the repository at this point in the history
Neither of these crates are depending on functionality added after the
original v1.0 release.

However, they were pinned to `1.2` instead of `1` following the latest
round of prereleases, effectively by mistake when the version in their
respective Cargo.toml files was changed from a prerelease to the final
release.

This makes these crates (and anything depending on them) mutually
incompatible with at least the `password-hash` crate, which has
`base64ct` pinned to prevent MSRV breakages:

https://github.com/RustCrypto/traits/runs/4239715372?check_suite_focus=true

```
error: failed to select a version for `base64ct`.
    ... required by package `spki v0.5.1`
    ... which satisfies dependency `spki = "^0.5"` of package `pkcs8 v0.8.0`
    ... which satisfies dependency `pkcs8 = "^0.8"` of package `sec1 v0.2.0`
    ... which satisfies dependency `sec1 = "^0.2"` of package `elliptic-curve v0.11.0-pre (/home/runner/work/traits/traits/elliptic-curve)`
    ... which satisfies path dependency `elliptic-curve` of package `crypto v0.4.0-pre (/home/runner/work/traits/traits/crypto)`
versions that meet the requirements `^1.2` are: 1.2.0

all possible versions conflict with previously selected packages.

  previously selected package `base64ct v1.0.1`
    ... which satisfies dependency `base64ct = ">=1, <1.1.0"` of package `password-hash v0.3.2 (/home/runner/work/traits/traits/password-hash)`
    ... which satisfies path dependency `password-hash` of package `crypto v0.4.0-pre (/home/runner/work/traits/traits/crypto)`

failed to select a version for `base64ct` which could resolve this conflict
```

Relaxing the version requirements fixes this incompatibility.
  • Loading branch information
tarcieri committed Nov 17, 2021
1 parent f210c63 commit e5cae09
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion pem-rfc7468/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ edition = "2021"
rust-version = "1.56"

[dependencies]
base64ct = { version = "1.2", path = "../base64ct" }
base64ct = { version = "1", path = "../base64ct" }

[features]
alloc = []
Expand Down
2 changes: 1 addition & 1 deletion spki/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ der = { version = "0.5", features = ["oid"], path = "../der" }

# Optional dependencies
sha2 = { version = "0.9.8", optional = true, default-features = false }
base64ct = { version = "1.2", path = "../base64ct", optional = true, default-features = false }
base64ct = { version = "1", path = "../base64ct", optional = true, default-features = false }

[dev-dependencies]
hex-literal = "0.3"
Expand Down

0 comments on commit e5cae09

Please sign in to comment.