-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump versions to prereleases for next release cycle #1296
Conversation
This bumps the following crates to prerelease versions: - `der`(_derive) v0.8.0-pre - `pem-rfc7468` v1.0.0-pre - `pkcs1` v0.8.0-pre - `pkcs5` v0.8.0-pre - `pkcs8` v0.11.0-pre - `sec1` v0.8.0-pre - `spki` v0.8.0-pre This notably doesn't bump `x509-cert` or any crates which are dependent upon it due to a circular dependency problem: the certificate builder tests rely on updated public key crypto crates like `rsa`, so we'll need to do this update in two phases: this initial set of format-only crates, and then updating the cryptographic dependencies. `pem-rfc7468` has been bumped to v1.0.0-pre based on the observation that there have been no significant changes since the last release, and that the baseline set of functionality it provides is stable.
@@ -19,9 +19,9 @@ rust-version = "1.65" | |||
arbitrary = { version = "1.3", features = ["derive"], optional = true } | |||
bytes = { version = "1", optional = true, default-features = false } | |||
const-oid = { version = "0.9.2", optional = true } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could that be an opportunity to bump this dependency as well?
(I believe you published const-oid yesterday?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Saving it for a followup due to #1293.
I'm going to make some API changes to it first before upgrading it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also upgrading needs prereleases of a bunch of the hash and cipher crates, due to their use of OIDs.
@@ -1,6 +1,6 @@ | |||
[package] | |||
name = "spki" | |||
version = "0.7.3" | |||
version = "0.8.0-pre" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you don't mind I'd love to include #1290 in there as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can just rebase/merge that after I land this, which is only bumping versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh I thought you'd be publishing that to crates.io too.
That was for the purpose of putting #1297 on top.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not yet (though I guess I usually note there's not a release associated with these PRs and forgot in this case).
This is just bumping versions to signal that breaking changes are coming.
Blocking on: - RustCrypto#1290 - RustCrypto#1296
Blocking on: - RustCrypto#1290 - RustCrypto#1296
For next release cycle, as was started in #1296. Due to circular dependencies (on e.g. digital signature libraries) this wasn't possible at that time, but is now that we've made prereleases of all of the requisite dependencies. This bumps the following crates to prerelease versions (not intended for release, just to signal we're making breaking changes): - `cmpv2` v0.3.0-pre - `cms` v0.3.0-pre - `crmf` v0.3.0-pre - `gss-api` v0.2.0-pre - `pkcs12` v0.2.0-pre - `x509-cert` v0.3.0-pre - `x509-ocsp` v0.3.0-pre - `x509-tsp` v0.2.0-pre See also: #1289
For next release cycle, as was started in #1296. Due to circular dependencies (on e.g. digital signature libraries) this wasn't possible at that time, but is now that we've made prereleases of all of the requisite dependencies. This bumps the following crates to prerelease versions (not intended for release, just to signal we're making breaking changes): - `cmpv2` v0.3.0-pre - `cms` v0.3.0-pre - `crmf` v0.3.0-pre - `gss-api` v0.2.0-pre - `pkcs12` v0.2.0-pre - `x509-cert` v0.3.0-pre - `x509-ocsp` v0.3.0-pre - `x509-tsp` v0.2.0-pre See also: #1289
For next release cycle, as was started in #1296. Due to circular dependencies (on e.g. digital signature libraries) this wasn't possible at that time, but is now that we've made prereleases of all of the requisite dependencies. This bumps the following crates to prerelease versions (not intended for release, just to signal we're making breaking changes): - `cmpv2` v0.3.0-pre - `cms` v0.3.0-pre - `crmf` v0.3.0-pre - `gss-api` v0.2.0-pre - `pkcs12` v0.2.0-pre - `x509-cert` v0.3.0-pre - `x509-ocsp` v0.3.0-pre - `x509-tsp` v0.2.0-pre See also: #1289
For next release cycle, as was started in #1296. Due to circular dependencies (on e.g. digital signature libraries) this wasn't possible at that time, but is now that we've made prereleases of all of the requisite dependencies. This bumps the following crates to prerelease versions (not intended for release, just to signal we're making breaking changes): - `cmpv2` v0.3.0-pre - `cms` v0.3.0-pre - `crmf` v0.3.0-pre - `gss-api` v0.2.0-pre - `pkcs12` v0.2.0-pre - `x509-cert` v0.3.0-pre - `x509-ocsp` v0.3.0-pre - `x509-tsp` v0.2.0-pre See also: #1289
This bumps the following crates to prerelease versions (not intended for release, just to signal we're making breaking changes):
der
(_derive) v0.8.0-prepem-rfc7468
v1.0.0-prepkcs1
v0.8.0-prepkcs5
v0.8.0-prepkcs8
v0.11.0-presec1
v0.8.0-prespki
v0.8.0-preThis notably doesn't bump
x509-cert
or any crates which are dependent upon it due to a circular dependency problem: the certificate builder tests rely on updated public key crypto crates likersa
, so we'll need to do this update in two phases: this initial set of format-only crates, and then updating the cryptographic dependencies.pem-rfc7468
has been bumped to v1.0.0-pre based on the observation that there have been no significant changes since the last release, and that the baseline set of functionality it provides is stable.