New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rust 2021 edition upgrade #136
Conversation
impl#generics tls_codec::Size for #ident#generics { | ||
impl #generics tls_codec::Size for #ident #generics { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@franziskuskiefer FYI, these were auto-corrected by cargo fix --edition
:
error: prefix `impl` is unknown
--> tls_codec/derive/src/lib.rs:234:17
|
234 | impl#generics tls_codec::Size for #ident#generics {
| ^^^^ unknown prefix
|
= note: prefixed identifiers and literals are reserved since Rust 2021
help: consider inserting whitespace here
|
234 - impl#generics tls_codec::Size for #ident#generics {
234 + impl #generics tls_codec::Size for #ident#generics {
See: https://doc.rust-lang.org/edition-guide/rust-2021/reserving-syntax.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻 well, if that's the only fix needed for 2021 I'm fine with that 😄
528ab7d
to
61d782d
Compare
Most of the crates in this repository were already MSRV 1.55 to take advantage of non-`Copy`/`Default` array constructors using the new const-generic `map` constructor. However, now that the 2021 edition is out, it would be a shame to bump to 1.55 instead of 1.56 when we're bumping MSRV anyway. This commit bumps `edition = "2021"`, also adding the new `rust-version = "1.56"` Cargo.toml attribute to properly signal MSRV. All crates have been checked using `cargo fix --edition`, however no attempts have yet been made at upgrading edition idioms.
61d782d
to
82cea22
Compare
The RustCrypto/formats repo was bumped to Rust 2021 edition, and some of those crates (e.g. `der`, `sec1`) are hard dependencies for the `elliptic-curve` crate: RustCrypto/formats#136 This is a corresponding Rust 2021 edition bump for the `elliptic-curve` crate, as well as the omnibus `crypto` crate whose MSRV is determined by the highest MSRV crate in this repo.
The RustCrypto/formats repo was bumped to Rust 2021 edition, and some of those crates (e.g. `der`, `sec1`) are hard dependencies for the `elliptic-curve` crate: RustCrypto/formats#136 To actually bump the crate to the 2021 edition, we need to bump the MSRV of the rest of the crates in the repo, so this commit only changes the MSRV and doesn't actually do a 2021 edition upgrade for the `elliptic-curve` crate yet.
The RustCrypto/formats repo was bumped to Rust 2021 edition, and some of those crates (e.g. `der`, `sec1`) are hard dependencies for the `elliptic-curve` crate: RustCrypto/formats#136 This is a corresponding Rust 2021 edition bump for the `elliptic-curve` crate, as well as the omnibus `crypto` crate whose MSRV is determined by the highest MSRV crate in this repo.
The RustCrypto/formats repo was bumped to Rust 2021 edition, and some of those crates (e.g. `der`, `sec1`) are hard dependencies for the `elliptic-curve` crate: RustCrypto/formats#136 This is a corresponding Rust 2021 edition bump for the `elliptic-curve` crate, as well as the omnibus `crypto` crate whose MSRV is determined by the highest MSRV crate in this repo.
The RustCrypto/formats repo was bumped to Rust 2021 edition, and some of those crates (e.g. `der`, `sec1`) are hard dependencies for the `elliptic-curve` crate: RustCrypto/formats#136 This is a corresponding Rust 2021 edition bump for the `elliptic-curve` crate, as well as the omnibus `crypto` crate whose MSRV is determined by the highest MSRV crate in this repo.
The RustCrypto/formats repo was bumped to Rust 2021 edition, and some of those crates (e.g. `der`, `sec1`) are hard dependencies for the `elliptic-curve` crate: RustCrypto/formats#136 This is a corresponding Rust 2021 edition bump for the `elliptic-curve` crate, as well as the omnibus `crypto` crate whose MSRV is determined by the highest MSRV crate in this repo.
The RustCrypto/formats repo was bumped to Rust 2021 edition, and some of those crates (e.g. `der`, `sec1`) are hard dependencies for the `elliptic-curve` crate: RustCrypto/formats#136 This is a corresponding Rust 2021 edition bump for the `elliptic-curve` crate, as well as the omnibus `crypto` crate whose MSRV is determined by the highest MSRV crate in this repo.
The RustCrypto/formats repo was bumped to Rust 2021 edition, and some of those crates (e.g. `der`, `sec1`) are hard dependencies for the `elliptic-curve` crate: RustCrypto/formats#136 This is a corresponding Rust 2021 edition bump for the `elliptic-curve` crate, as well as the omnibus `crypto` crate whose MSRV is determined by the highest MSRV crate in this repo.
Most of the crates in this repository were already MSRV 1.55 to take advantage of non-
Copy
/Default
array constructors using the new const-genericmap
constructor.However, now that the 2021 edition is out, it would be a shame to bump to 1.55 instead of 1.56 when we're bumping MSRV anyway.
This commit bumps
edition = "2021"
, also adding the newrust-version = "1.56"
Cargo.toml attribute to properly signal MSRV.All crates have been checked using
cargo fix --edition
, however no attempts have yet been made at upgrading edition idioms.