const-oid: make length the first field of ObjectIdentifier
#178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This primarily impacts how the derived `PartialOrd`/`Ord` impls behave. It ensures that the longer OID is always greater.
tarcieri
added a commit
that referenced
this pull request
Nov 4, 2021
These were failing to parse correctly until inadvertently fixed by #178. The problem is not fully addressed, but it's good to at least capture it in a regression test to prevent future breakages. Note that this test also seems to be uncovering another bug in `const-oid` which will get separately addressed in a followup.
tarcieri
added a commit
that referenced
this pull request
Nov 4, 2021
These were failing to parse correctly until inadvertently fixed by #178. The problem is not fully addressed, but it's good to at least capture it in a regression test to prevent future breakages. Note that this test also seems to be uncovering another bug in `const-oid` which will get separately addressed in a followup.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This primarily impacts how the derived
PartialOrd/Ordimpls behave.It ensures that the longer OID is always greater.