Import sources from RustCrypto/utils #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Crates in this repo were originally developed at: https://github.com/rustcrypto/utils They were imported as of this commit: commit c60c25672e1c6d06b74b7d1aa6a9a19935d71e25 Author: Daniel James <dwhjames@gmail.com> Date: Tue Sep 14 06:01:54 2021 -0700 expand algorithm coverage for PBES2-PBKDF2 (#633) This commit also includes some tweaks to move the repo, e.g. updating links to point to the new location.
tarcieri
added a commit
to RustCrypto/utils
that referenced
this pull request
Sep 14, 2021
Splits out PKCS and X.509-related crates into a new repo: RustCrypto/formats#2 This PR leaves a directory for each of these crates in-place with a README.md pointing to the new location. We can eventually remove these, perhaps sometime after we've published new versions of all of the format-related crates which point to the new location.
tarcieri
added a commit
to RustCrypto/utils
that referenced
this pull request
Sep 14, 2021
Splits out PKCS and X.509-related crates into a new repo: RustCrypto/formats#2 This PR leaves a directory for each of these crates in-place with a README.md pointing to the new location. We can eventually remove these, perhaps sometime after we've published new versions of all of the format-related crates which point to the new location.
This was referenced Sep 14, 2021
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
baloo
added a commit
to baloo/formats
that referenced
this pull request
Jan 3, 2023
The naming of the `to_owned` method was a bit unfortunate as it
triggered conflicts with the `alloc::borrow::ToOwned` method. When used,
this would make for compiler messages asking things like:
```
error[E0034]: multiple applicable items in scope
--> certval/src/validator/name_constraints_set.rs:748:34
|
748 | value: a.to_owned(),
| ^^^^^^^^ multiple `to_owned` found
|
= note: candidate RustCrypto#1 is defined in an impl of the trait `RefToOwned` for the type `AnyRef<'a>`
= note: candidate RustCrypto#2 is defined in an impl of the trait `ToOwned` for the type `T`
help: disambiguate the associated function for candidate RustCrypto#1
|
748 | value: RefToOwned::to_owned(&a),
| ~~~~~~~~~~~~~~~~~~~~~~~~
help: disambiguate the associated function for candidate RustCrypto#2
|
748 | value: ToOwned::to_owned(&a),
| ~~~~~~~~~~~~~~~~~~~~~
```
tarcieri
pushed a commit
that referenced
this pull request
Jan 3, 2023
The naming of the `to_owned` method was a bit unfortunate as it
triggered conflicts with the `alloc::borrow::ToOwned` method. When used,
this would make for compiler messages asking things like:
```
error[E0034]: multiple applicable items in scope
--> certval/src/validator/name_constraints_set.rs:748:34
|
748 | value: a.to_owned(),
| ^^^^^^^^ multiple `to_owned` found
|
= note: candidate #1 is defined in an impl of the trait `RefToOwned` for the type `AnyRef<'a>`
= note: candidate #2 is defined in an impl of the trait `ToOwned` for the type `T`
help: disambiguate the associated function for candidate #1
|
748 | value: RefToOwned::to_owned(&a),
| ~~~~~~~~~~~~~~~~~~~~~~~~
help: disambiguate the associated function for candidate #2
|
748 | value: ToOwned::to_owned(&a),
| ~~~~~~~~~~~~~~~~~~~~~
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Crates in this repo were originally developed at:
https://github.com/rustcrypto/utils
They were imported as of this commit:
This commit also includes some tweaks to move the repo, e.g. updating links to point to the new location.