Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pem-rfc7468: rename Error::HeaderDisallowed #21

Merged
merged 1 commit into from
Sep 14, 2021

Conversation

tarcieri
Copy link
Member

It was previously Error::HeaderDetected, however that doesn't really indicate why it's an error.

The new error message notes that headers are explicitly disallowed in the RFC7468 interpretation of PEM.

cc @dwhjames

It was previously `Error::HeaderDetected`, however that doesn't really
indicate why it's an error.

The new error message notes that headers are explicitly disallowed in
the RFC7468 interpretation of PEM.
Copy link
Contributor

@dwhjames dwhjames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tarcieri tarcieri merged commit c406b5a into master Sep 14, 2021
@tarcieri tarcieri mentioned this pull request Sep 14, 2021
@tarcieri tarcieri deleted the pem-rfc7468/header-disallowed branch October 6, 2021 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants