feat(spki): impl PartialOrd for AlgorithmIdentifier #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarcieri
reviewed
Mar 7, 2022
spki/src/algorithm.rs
Outdated
| @@ -14,7 +14,7 @@ use der::{Decodable, DecodeValue, Decoder, DerOrd, Encodable, Header, Sequence, | |||
| /// ``` | |||
| /// | |||
| /// [RFC 5280 Section 4.1.1.2]: https://tools.ietf.org/html/rfc5280#section-4.1.1.2 | |||
| #[derive(Copy, Clone, Debug, Eq, PartialEq)] | |||
| #[derive(Copy, Clone, Debug, Eq, PartialEq, PartialOrd)] | |||
There was a problem hiding this comment.
Might as well add Ord at this point
There was a problem hiding this comment.
Most of the testing was with Ord. It was dropped while preparing the PR as not necessary to satisfy the requirements generated by the partial SignedData impl
There was a problem hiding this comment.
I just added Ord.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@carl-wallace FYI