-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
der: Document
and SecretDocument
types
#571
Conversation
ce80f42
to
156e8a4
Compare
d4da146
to
7e991f5
Compare
Document
and SecretDocument
typesDocument
and SecretDocument
types
7e991f5
to
933122e
Compare
Removing WIP/draft. The core implementation is effectively done, although could probably use some additional work to reduce repetitiveness. Still, this removes quite a bit of duplicated code from the original implementation. I'm going to continue adding additional/replacement tests for the format-specific |
933122e
to
3d998bc
Compare
@@ -1,97 +0,0 @@ | |||
//! CertificateDocument implementation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@carl-wallace FYI, ended up removing this along with all of the format-specific *Document
types. Hope the Document
type works for your use cases
bf3ca08
to
4ad135f
Compare
Replaces the previous `Document` trait with types for wrapping serialized ASN.1 DER SEQUENCEs stored on the heap. The `SecretDocument` is composed in terms of `Document` and provides some additional hardening for sensitive data, namely zeroize-on-drop and file permissions hardening when writing to disk. This commit also removes all of the format-specific `*Document` types found in the `pkcs1`, `pkcs8`, `spki`, and `sec1` crates with the new `Document` and `SecretDocument` types.
4ad135f
to
7104154
Compare
Replaces the previous
Document
trait with types for wrapping serialized ASN.1 DER SEQUENCEs stored on the heap.The
SecretDocument
is composed in terms ofDocument
and provides some additional hardening for sensitive data, namely zeroize-on-drop and file permissions hardening when writing to disk.This commit also removes all of the format-specific
*Document
types found in thepkcs1
,pkcs8
,spki
, andsec1
crates with the newDocument
andSecretDocument
types.