pkcs1: implement support for PSS Params structure #698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarcieri
reviewed
Aug 15, 2022
tarcieri
reviewed
Aug 15, 2022
lumag
force-pushed
the
pkcs1-params
branch
3 times, most recently
from
11f81a5
to
b9700f9
Compare
|
@tarcieri simplified the implementation to use |
Add support for parsing and generatign RSA PSS params. Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
tarcieri
reviewed
Aug 27, 2022
| /// | ||
| /// [RFC 8017 Appendix 2.3]: https://datatracker.ietf.org/doc/html/rfc8017#appendix-A.2.3 | ||
| #[derive(Clone, Debug, Eq, PartialEq, Sequence)] | ||
| pub struct RsaPSSParameters<'a> { |
There was a problem hiding this comment.
Per RFC 430 naming conventions, this should be:
Suggested change
| pub struct RsaPSSParameters<'a> { | |
| pub struct RsaPssParameters<'a> { |
tarcieri
requested changes
Aug 27, 2022
tarcieri
approved these changes
Aug 28, 2022
tarcieri
added a commit
that referenced
this pull request
Aug 28, 2022
Followup to #698. - Renames `RsaPSSParameters` => `RsaPssParams` - Removes use of the `der` crate's `derive` feature The `rsa` crate curently doesn't need any custom derive, and adding it here would make it a hard requirement. We can consider switching to custom derive in `pkcs1`, but if we do it then it should be wholesale for all types in the crate, not using custom derive for some types and handwritten impls for others.
tarcieri
added a commit
that referenced
this pull request
Aug 28, 2022
Followup to #698. - Renames `RsaPSSParameters` => `RsaPssParams` - Removes use of the `der` crate's `derive` feature The `rsa` crate curently doesn't need any custom derive, and adding it here would make it a hard requirement. We can consider switching to custom derive in `pkcs1`, but if we do it then it should be wholesale for all types in the crate, not using custom derive for some types and handwritten impls for others.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for parsing and generatign RSA PSS params.
Signed-off-by: Dmitry Baryshkov dmitry.baryshkov@linaro.org