Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x509-cert: SerialNumber is now a specialized object #795

Merged
merged 5 commits into from
Dec 18, 2022
Merged

x509-cert: SerialNumber is now a specialized object #795

merged 5 commits into from
Dec 18, 2022

Conversation

baloo
Copy link
Member

@baloo baloo commented Dec 13, 2022

No description provided.

baloo
baloo commented Dec 13, 2022
View reviewed changes
x509-cert/src/serial_number.rs Outdated Show resolved Hide resolved
baloo
baloo commented Dec 16, 2022
View reviewed changes
der/src/asn1/integer/bigint.rs Outdated Show resolved Hide resolved
@baloo baloo force-pushed the baloo/owned-api/serial-number branch from d59fc14 to 22ea7be Compare December 18, 2022 03:47
tarcieri
tarcieri approved these changes Dec 18, 2022
View reviewed changes
Copy link
Member

@tarcieri tarcieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion but it’s a tiny nit and I could go either way

@tarcieri tarcieri merged commit a8a0b04 into RustCrypto:master Dec 18, 2022
@baloo baloo deleted the baloo/owned-api/serial-number branch December 18, 2022 05:23
@tarcieri tarcieri mentioned this pull request Mar 19, 2023
Merged
@lumag lumag mentioned this pull request Apr 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarcieri tarcieri tarcieri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@baloo @tarcieri