Remove ArrayOps and SliceOps
#30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After #24, #25, and #26, these traits don't really need to exist and have largely been replaced by safe type conversions with appropriate bounds. In lieu of `ArrayOps<T, N>` we instead can use `U: ArraySize<ArrayType<T> = [T; N]>>` as a bound, which albeit a bit more verbose concretely describes the inner type of `Array` to the compiler. The `cast_slice_(to|from)_core(_mut)` methods previously defined on the trait have been preserved, but as static methods of `Array`, making the change largely a drop in replacement. Places where they were being called as e.g. `ArrayOps::cast_slice_to_core` just need to be called as `Array::cast_slice_to_core` instead.
newpavlov
approved these changes
Jan 27, 2024
tarcieri
added a commit
to RustCrypto/hashes
that referenced
this pull request
Jan 28, 2024
This was a breaking change: RustCrypto/hybrid-array#30 This PR includes the necessary updates to remain compatible.
tarcieri
added a commit
to RustCrypto/hashes
that referenced
this pull request
Jan 28, 2024
This was a breaking change: RustCrypto/hybrid-array#30 This PR includes the necessary updates to remain compatible.
tarcieri
added a commit
to RustCrypto/hashes
that referenced
this pull request
Jan 29, 2024
This was a breaking change: RustCrypto/hybrid-array#30 This PR includes the necessary updates to remain compatible.
tarcieri
added a commit
to RustCrypto/hashes
that referenced
this pull request
Jan 29, 2024
This was a breaking change: RustCrypto/hybrid-array#30 This PR includes the necessary updates to remain compatible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #24, #25, and #26, these traits don't really need to exist and have largely been replaced by safe type conversions with appropriate bounds.
In lieu of
ArrayOps<T, N>we instead can useU: ArraySize<ArrayType<T> = [T; N]>>as a bound, which albeit a bit more verbose concretely describes the inner type ofArrayto the compiler.The
cast_slice_(to|from)_core(_mut)methods previously defined on the trait have been preserved, but as static methods ofArray, making the change largely a drop in replacement. Places where they were being called as e.g.ArrayOps::cast_slice_to_corejust need to be called asArray::cast_slice_to_coreinstead.