Expand array sizes through U1024 #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For some reason I don't see this on a local build, though? It would seem prudent to adopt only multiples of some power of two for these larger sizes, like I suggested in #45 Edit: this is actually a difference between 1.65 and stable, which explains why it built so fast locally. It looks like it currently takes 3m to build on 1.65: https://github.com/RustCrypto/hybrid-array/actions/runs/7923269699/job/21632628872 Edit again: opened #47 to track this. |
Post-quantum schemes like Kyber/Saber require sizes larger than what is currently supported. This extends the allowed array sizes through U1024, stepping by multiples of 16, although that still won't be enough to cover all cases needed for Kyber/Saber. However, it's the current limit of what `typenum` provides convenient type aliases for. Beyond that we'll either need to define our own types / type aliases.
tarcieri
force-pushed
the
expand-sizes-to-1024
branch
from
406f314
to
9b9da26
Compare
|
Using multiples of 16 for sizes above 256 has reduced build times to 2s again, although we'll still need a solution for sizes >1024. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Post-quantum schemes like Kyber/Saber require sizes larger than what is currently supported.
This extends the allowed array sizes through U1024 in multiples of 16, although that still won't be enough to cover all cases.
However, it's the current limit of what
typenumprovides convenient type aliases for.