Missing array sizes for hashes serialization #65
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baloo
force-pushed
the
baloo/array-sizes
branch
from
61f05d7
to
f1820c6
Compare
|
Hmm, I think it'd be good to keep the sizes which aren't gated under Maybe we can just expand the sizes that are always available up to 512. |
tarcieri
added a commit
that referenced
this pull request
Mar 17, 2024
This expands support for array sizes between 256-512, supporting all sizes in this range rather than just multiples of 16. Alternative to #65
tarcieri
added a commit
that referenced
this pull request
Mar 17, 2024
This expands support for array sizes between 256-512, supporting all sizes in this range rather than just multiples of 16. Alternative to #65
|
I opened #67 as an alternative which supports all array sizes up to 512 |
tarcieri
added a commit
that referenced
this pull request
Mar 17, 2024
|
Closing in favor of #67 |
|
I didn't read the rules on top of the module. My bad. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see RustCrypto/hashes#574 for more context