Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

argon2: use blake2 crate for round implementation #105

Closed
tarcieri opened this issue Jan 29, 2021 · 2 comments
Closed

argon2: use blake2 crate for round implementation #105

tarcieri opened this issue Jan 29, 2021 · 2 comments
Labels
argon2 Argon2 key derivation function enhancement

Comments

@tarcieri
Copy link
Member

The argon2 crate presently vendors its own implementation of the BLAKE2b round function for the core of the Argon2 KDF implementation:

https://github.com/RustCrypto/password-hashes/blob/58bc6dd/argon2/src/block.rs#L100-L186

Ideally it'd be able to leverage an implementation from the blake2 crate (which would give us a single place to focus on e.g. SIMD optimizations)

@Pjottos
Copy link
Contributor

Pjottos commented Sep 30, 2021

I don't think this is feasible, since Argon2 uses a modified version of the round function.
See the Argon2 and Blake2 RFCs

dns2utf8 pushed a commit to dns2utf8/password-hashes that referenced this issue Jan 24, 2023
…ersal-hash

.github: add universal-hash configuration
@tarcieri
Copy link
Member Author

tarcieri commented Mar 5, 2023

@Pjottos agreed

@tarcieri tarcieri closed this as completed Mar 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
argon2 Argon2 key derivation function enhancement
Projects
None yet
Development

No branches or pull requests

2 participants