Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable password-hash/std feature #141

Merged
merged 1 commit into from
Feb 28, 2021
Merged

Enable password-hash/std feature #141

merged 1 commit into from
Feb 28, 2021

Conversation

li-kai
Copy link
Contributor

@li-kai li-kai commented Feb 28, 2021

Enables password-hash/std feature, allowing crates like argon2 to throw error up from password-hash.

This is helpful in situations where you want to bubble up the error:

error[E0277]: the trait bound `HashError: StdError` is not satisfied
   --> auth/src/models.rs:104:47
    |
104 |     let parsed_hash = PasswordHash::new(&hash)?;
    |                                               ^ the trait `StdError` is not implemented for `HashError`
    |
    = note: required because of the requirements on the impl of `From<HashError>` for `anyhow::Error`
    = note: required by `std::convert::From::from`

@tarcieri
Copy link
Member

Thank you! This seems like an oversight.

@tarcieri tarcieri merged commit 49db66f into RustCrypto:master Feb 28, 2021
@tarcieri tarcieri mentioned this pull request Feb 28, 2021
This was referenced Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants