argon2: avoid salt-length related panic (closes #134) #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarcieri
force-pushed
the
argon2/fix-salt-length-panic
branch
2 times, most recently
from
549a8a5
to
00b4ee0
Compare
Adds some additional advance checks that Argon2 parameters are within range, and returns errors in the event they are not. This prevents a panic caused by what was previously an `unimplemented!` call when converting error types. The occurrence of the panic in the first place speaks to overall deficienciesin the `password-hash` crate's error handling strategy. It's further complicated by the awkwardness of the `password_hash::Output::init_with` API. The code in this commit has TODOs for addressing the above, but it'd be good to open issues upstream on the `password-hash` crate about these problems, and ideally update the TODOs in the code with references to the issues.
tarcieri
force-pushed
the
argon2/fix-salt-length-panic
branch
from
00b4ee0
to
a4b5e03
Compare
|
@izik1 unfortunately this doesn't give a good error for incorrect salt lengths (it's presently I'll open some issues about improving the error handling story in |
This was referenced Feb 13, 2021
Merged
tarcieri
added a commit
that referenced
this pull request
May 28, 2021
Now that error handling has been improved in `password-hash` v0.2, these are no longer needed as the errors will be properly handled in the `hash_password_into` function.
tarcieri
added a commit
that referenced
this pull request
May 28, 2021
Now that error handling has been improved in `password-hash` v0.2, these are no longer needed as the errors will be properly handled in the `hash_password_into` function.
tarcieri
added a commit
that referenced
this pull request
May 28, 2021
dns2utf8
pushed a commit
to dns2utf8/password-hashes
that referenced
this pull request
Jan 24, 2023
universal-hash: split out NewUniversalHash trait
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds some additional advance checks that Argon2 parameters are within range, and returns errors in the event they are not.
This prevents a panic caused by what was previously an
unimplemented!call when converting error types.The occurrence of the panic in the first place speaks to overall deficiencies in the
password-hashcrate's error handling strategy.It's further complicated by the awkwardness of the
password_hash::Output::init_withAPI.The code in this commit has TODOs for addressing the above, but it'd be good to open issues upstream on the
password-hashcrate about these problems, and ideally update the TODOs in the code with references to the issues.cc @izik1