Signature support: ECDSA and Ed25519 #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a toplevel `signature` module with `ecdsa` and `ed25519` submodules.
newpavlov
reviewed
Oct 9, 2020
| const TEST_VECTORS: &[TestVector] = &[ | ||
| TestVector { | ||
| sk: b"\x9D\x61\xB1\x9D\xEF\xFD\x5A\x60\xBA\x84\x4A\xF4\x92\xEC\x2C\xC4\x44\x49\xC5\x69\x7B\x32\x69\x19\x70\x3B\xAC\x03\x1C\xAE\x7F\x60", | ||
| pk: b"\xD7\x5A\x98\x01\x82\xB1\x0A\xB7\xD5\x4B\xFE\xD3\xC9\x64\x07\x3A\x0E\xE1\x72\xF3\xDA\xA6\x23\x25\xAF\x02\x1A\x68\xF7\x07\x51\x1A", |
There was a problem hiding this comment.
Use hex-literal to make these vectors more compact?
There was a problem hiding this comment.
@newpavlov yeah, can do that. might do it in a follow-up (this was just the most convenient form to copy/paste them in)
There was a problem hiding this comment.
Actually it's a bit tricky, since they're differently-sized...
There was a problem hiding this comment.
IIRC &hex!("0123")[..] should do the job.
There was a problem hiding this comment.
Yeah that should be fine. I guess on 1.47.0+ we can do .as_ref()?
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a toplevel
signaturemodule withecdsaanded25519submodules.