Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken CI because of working-directory #440

Closed
daxpedda opened this issue Jan 19, 2022 · 1 comment · Fixed by #442
Closed

Broken CI because of working-directory #440

daxpedda opened this issue Jan 19, 2022 · 1 comment · Fixed by #442

Comments

@daxpedda
Copy link
Contributor

It seems I have broken the CI because I didn't know that you can only use working-directory with run and not with uses. The reason I didn't notice was because for some reason these jobs didn't show up in the PR.
This was referenced Jan 19, 2022
Closed
Merged
tarcieri added a commit that referenced this issue Jan 19, 2022
@tarcieri
Reunify workspace; disable ring-compat doctests
f5858d0 
Reverts the changes from #433 that split the `ed25519` crate out into
its own namespace.

Instead, temporarily disables the `ring-compat` dependency and doctests
in the `ed25519` crate until it's updated to the latest version of the
`signature` crate.

Fixes #440
@tarcieri tarcieri mentioned this issue Jan 19, 2022
Merged
@tarcieri
Copy link
Member

Alternative solution for this here which combines the crates back into a single workspace again: #442

tarcieri added a commit that referenced this issue Jan 19, 2022
@tarcieri
Reunify workspace; disable ring-compat doctests (#442)
392be55 
Reverts the changes from #433 that split the `ed25519` crate out into
its own namespace.

Instead, temporarily disables the `ring-compat` dependency and doctests
in the `ed25519` crate until it's updated to the latest version of the
`signature` crate.

Fixes #440
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@tarcieri @daxpedda