Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ecdsa: bump ff and group crates to v0.8; MSRV 1.44+ #156

Merged
merged 1 commit into from
Sep 9, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
13 changes: 9 additions & 4 deletions .github/workflows/ecdsa.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
- thumbv7em-none-eabi
- wasm32-unknown-unknown
rust:
- 1.41.0 # MSRV
- 1.44.0 # MSRV
- stable
steps:
- uses: actions/checkout@v1
Expand All @@ -35,15 +35,20 @@ jobs:
target: ${{ matrix.target }}
override: true
- run: cargo build --no-default-features --release --target ${{ matrix.target }}
- run: cargo build --no-default-features --features sign --release --target ${{ matrix.target }}
- run: cargo build --no-default-features --features verify --release --target ${{ matrix.target }}
- run: cargo build --no-default-features --release --target ${{ matrix.target }} --features arithmetic
- run: cargo build --no-default-features --release --target ${{ matrix.target }} --features digest
- run: cargo build --no-default-features --release --target ${{ matrix.target }} --features hazmat
- run: cargo build --no-default-features --release --target ${{ matrix.target }} --features sign
- run: cargo build --no-default-features --release --target ${{ matrix.target }} --features verify
- run: cargo build --no-default-features --release --target ${{ matrix.target }} --features zeroize
- run: cargo build --no-default-features --release --target ${{ matrix.target }} --features arithmetic,digest,hazmat,sign,verify,zeroize

test:
runs-on: ubuntu-latest
strategy:
matrix:
rust:
- 1.41.0 # MSRV
- 1.44.0 # MSRV
- stable
steps:
- uses: actions/checkout@v1
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/workspace.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ jobs:
- uses: actions-rs/toolchain@v1
with:
profile: minimal
toolchain: stable
toolchain: 1.44.0 # Highest MSRV in repo
components: clippy
- run: cargo clippy --all-features -- -D warnings

Expand Down
44 changes: 37 additions & 7 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,3 @@ members = ["ecdsa", "ed25519"]

[patch.crates-io]
elliptic-curve = { git = "https://github.com/RustCrypto/traits" }
group = { git = "https://github.com/zkcrypto/group.git" }
7 changes: 4 additions & 3 deletions ecdsa/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,13 @@ sha2 = { version = "0.9", default-features = false }
[features]
default = ["digest"]
alloc = []
dev = ["digest", "zeroize"]
arithmetic = ["elliptic-curve/arithmetic"]
dev = ["arithmetic", "digest", "zeroize"]
digest = ["elliptic-curve/digest", "signature/digest-preview"]
hazmat = []
sign = ["digest", "hazmat", "hmac", "zeroize"]
sign = ["arithmetic", "digest", "hazmat", "hmac", "zeroize"]
std = ["alloc", "elliptic-curve/std", "signature/std"]
verify = ["digest", "hazmat"]
verify = ["arithmetic", "digest", "hazmat"]
zeroize = ["elliptic-curve/zeroize"]

[package.metadata.docs.rs]
Expand Down
4 changes: 2 additions & 2 deletions ecdsa/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ ways:

## Minimum Supported Rust Version

- Rust **1.41+**
- Rust **1.44+**

## License

Expand All @@ -50,7 +50,7 @@ dual licensed as above, without any additional terms or conditions.
[docs-image]: https://docs.rs/ecdsa/badge.svg
[docs-link]: https://docs.rs/ecdsa/
[license-image]: https://img.shields.io/badge/license-Apache2.0/MIT-blue.svg
[rustc-image]: https://img.shields.io/badge/rustc-1.41+-blue.svg
[rustc-image]: https://img.shields.io/badge/rustc-1.44+-blue.svg
[build-image]: https://github.com/RustCrypto/signatures/workflows/ecdsa/badge.svg?branch=master&event=push
[build-link]: https://github.com/RustCrypto/signatures/actions?query=workflow%3Aecdsa

Expand Down