ecdsa: remove SignPrimitive and VerifyPrimitive traits
#793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarcieri
force-pushed
the
ecdsa/remove-signprimitive-and-verifyprimitive-traits
branch
3 times, most recently
from
76c58b4
to
4948b56
Compare
The backstory of these traits was once upon a time we didn't yet have the trait structure in place to express algorithms like ECDSA signing and verification generically, so each crate (at the time just `k256` and `p256`) had a nearly duplicated implementation of ECDSA, with `k256` including tweaks for low-S normalization. Now the `ecdsa` crate contains fully generic implementations of both algorithms, and with the `EcdsaCurve` trait, carries a `NORMALIZE_S` preference, so these traits are just needless indirection at this point. This removes the traits, converting non-trivial methods into static functions in the `hazmat` module, namely `sign_prehashed_rfc6979`.
tarcieri
force-pushed
the
ecdsa/remove-signprimitive-and-verifyprimitive-traits
branch
from
4948b56
to
0ab00f1
Compare
tarcieri
deleted the
ecdsa/remove-signprimitive-and-verifyprimitive-traits
branch
tarcieri
added a commit
to RustCrypto/elliptic-curves
that referenced
this pull request
Jan 18, 2024
These were removed upstream in RustCrypto/signatures#793. The ECDSA implementation is fully generic now. These traits were originally for per-curve implementations, but those are no-longer needed. The upstream implementation now has native support for low-S normalization by way of `EcdsaCurve::NORMALIZE_S`.
tarcieri
added a commit
to RustCrypto/elliptic-curves
that referenced
this pull request
Jan 18, 2024
These were removed upstream in RustCrypto/signatures#793. The ECDSA implementation is fully generic now. These traits were originally for per-curve implementations, but those are no-longer needed. The upstream implementation now has native support for low-S normalization by way of `EcdsaCurve::NORMALIZE_S`.
tarcieri
added a commit
to RustCrypto/elliptic-curves
that referenced
this pull request
Jan 18, 2024
These were removed upstream in RustCrypto/signatures#793. The ECDSA implementation is fully generic now. These traits were originally for per-curve implementations, but those are no-longer needed. The upstream implementation now has native support for low-S normalization by way of `EcdsaCurve::NORMALIZE_S`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The backstory of these traits was once upon a time we didn't yet have the trait structure in place to express algorithms like ECDSA signing and verification generically, so each crate (at the time just
k256andp256) had a nearly duplicated implementation of ECDSA, withk256including tweaks for low-S normalization.Now the
ecdsacrate contains fully generic implementations of both algorithms, and with theEcdsaCurvetrait, carries aNORMALIZE_Spreference, so these traits are just needless indirection at this point.This removes the traits, converting non-trivial methods into static functions in the
hazmatmodule, namelysign_prehashed_rfc6979.