Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary DigestPrimitive bound on PrehashVerifier #823

Merged
merged 1 commit into from
May 18, 2024
Merged

Remove unnecessary DigestPrimitive bound on PrehashVerifier #823

merged 1 commit into from
May 18, 2024

Conversation

Leo1003
Copy link
Contributor

@Leo1003 Leo1003 commented May 15, 2024 •
edited

I am using verify_prehash() with P521 curve to verify a der::Signature and find that I cannot compile the codes because that DigestPrimitive is not implemented for NistP521.

I think there is no need to add this trait bound after I invested the codes. I wonder If this is something forget to be removed.

-- From Zulip topic

@tarcieri
Copy link
Member

Aah sorry, it seems there are some new lints on stable Rust which have broken the build. The failures look unrelated to your changes.

@tarcieri
Copy link
Member

@Leo1003 can you rebase? #824 should take care of the build failures

@Leo1003
Copy link
Contributor Author

Leo1003 commented May 17, 2024

@Leo1003 can you rebase? #824 should take care of the build failures

Rebased & Passed the CI successfully

@tarcieri tarcieri merged commit 21a9dfb into RustCrypto:master May 18, 2024
8 checks passed
@tarcieri
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Leo1003 @tarcieri