Use portable_simd instead of deprecate packed_simd #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e29a53e.
aewag
force-pushed
the
use-portable-simd
branch
4 times, most recently
from
3e0b569
to
11995ea
Compare
aewag
force-pushed
the
use-portable-simd
branch
2 times, most recently
from
b19948c
to
e801123
Compare
tarcieri
approved these changes
May 24, 2022
newpavlov
reviewed
May 24, 2022
There was a problem hiding this comment.
The simd feature was previously working on stable, so this PR is strictly speaking introduces a breaking change, no? (Alternatively we could yank v0.1.1 and pretend that simd was never working on stable.) We probably need to add a comment to the Cargo.toml stating that simd currently requires Nightly.
Also I think with this change we can remove the dependencies section completely.
|
@newpavlov to my knowledge both The README.md says the following: https://crates.io/crates/packed_simd_2
|
|
@tarcieri Ah, true. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tarcieri I just migrated to use portable_simd.
EDIT: Just force-pushed to remove an unnecessary change, which I didnot spot before.