keccak: Add keccak_p fns for [200, 400, 800, 1600] #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aewag
force-pushed
the
add-fixed-sized-keccak-p-routines
branch
2 times, most recently
from
c72f5df
to
4ef70ec
Compare
Due to the generics approach of the keccak_p routine, the performance degrades significantly. To encounter this the commonly used functions are now defined by macros.
aewag
force-pushed
the
add-fixed-sized-keccak-p-routines
branch
from
4ef70ec
to
f434463
Compare
|
This approach looks ok to me and appears to be backwards compatible? |
|
Yes. It only adds the functions in addition to the existing ones. |
tarcieri
approved these changes
Apr 30, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the generics approach of the keccak_p routine, the performance degrades significantly. To encounter this the commonly used functions are now defined by macros.
See RustCrypto/hashes#468 for issue raised about performance degradation.