Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add generic keccak-p and keccak-f {200, 400, 800} #7

Merged
merged 1 commit into from
May 11, 2022

Conversation

aewag
Copy link
Contributor

@aewag aewag commented Dec 28, 2021

This PR sits on top of #6 (only the last commit is relevant).
CI was ran on my fork: aewag#2

This closes #1.

@aewag aewag force-pushed the 1-add-keccak-p branch 3 times, most recently from 8a117c9 to c3e755a Compare January 3, 2022 22:10
@aewag aewag marked this pull request as draft January 3, 2022 22:49
@aewag aewag force-pushed the 1-add-keccak-p branch 5 times, most recently from 7858e71 to 1a08306 Compare January 4, 2022 08:54
@aewag
Copy link
Contributor Author

aewag commented Jan 4, 2022

I could not find any generic testvectors for keccak_p. For testing k12 was refactored to use the keccak crate:

aewag/hashes#1

@aewag aewag marked this pull request as ready for review January 4, 2022 09:09
@aewag aewag mentioned this pull request Jan 13, 2022
@aewag aewag force-pushed the 1-add-keccak-p branch 2 times, most recently from ef061b5 to 277ec35 Compare January 26, 2022 08:07
@aewag
Copy link
Contributor Author

aewag commented Jan 26, 2022

Rebased on top of merged #6

@aewag
Copy link
Contributor Author

aewag commented Feb 11, 2022

@newpavlov Does this match with what you expected for #1?

The implementation is already prepared to allow an easy extension for SIMD, see #8.

@tarcieri
Copy link
Member

This seems simple enough, thanks!

@tarcieri tarcieri merged commit a2ef49e into RustCrypto:master May 11, 2022
@tarcieri tarcieri mentioned this pull request May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MIssing sponge functions
2 participants