You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
warning: value assigned to `word_idx` is never read
--> salsa20-core/src/salsa_family_state.rs:96:25
|
96 | word_idx = 0;
| ^^^^^^^^
|
= note: #[warn(unused_assignments)] on by default
= help: maybe it is overwritten before being read?
It's unclear to me what the intention was here, or if it can simply be removed. The "maybe it is overwritten before being read" help text has me curious if in the refactor it isn't being preserved somewhere it needed to be read, or if it's now being unconditionally overwritten in a way it shouldn't be.
The text was updated successfully, but these errors were encountered:
Have CI fail on warnings.
There's one warning across the workspace in the `salsa20-crate`.
I opened an issue about it here:
#23
I've gone ahead and thrown an `allow` attribute on the relevant code so
CI passes, which should at least prevent additional warnings from going
uncaught on CI.
cc @emc2 @sseemayer
There's presently a warning for
salsa20-core
:https://github.com/RustCrypto/stream-ciphers/blob/1dc6af/salsa20-core/src/salsa_family_state.rs#L96
Warning from CI:
https://travis-ci.org/RustCrypto/stream-ciphers/jobs/571061677#L202
It's unclear to me what the intention was here, or if it can simply be removed. The "maybe it is overwritten before being read" help text has me curious if in the refactor it isn't being preserved somewhere it needed to be read, or if it's now being unconditionally overwritten in a way it shouldn't be.
The text was updated successfully, but these errors were encountered: