Split up salsa20-family crate into salsa20-core, salsa20 and chacha20 #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sseemayer
force-pushed
the
split-salsa20-family
branch
from
3f00740
to
dc2996b
Compare
|
Apologies about the larger-than necessary diffs, especially 9e52d49 . I have set up my editor to automatically run |
sseemayer
commented
Jun 23, 2019
|
At the first glance looks good to me! @tarcieri |
|
Yep, I can look later today. |
tarcieri
approved these changes
Jun 24, 2019
|
Looks good to me as well. Thanks for the help! @emc2 this would be good for you to (retroactively) review as well, if you have time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR to split up
salsa20-familyintosalsa20-core,salsa20andchacha20as discussed in #15 .