Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added rfc7539-section-242 test #244

Conversation

seanybaggins
Copy link

Not 100% sure if the test was put in the correct location. Comments welcome.

@tarcieri
Copy link
Member

Hmm, I'm not sure if these are the same vectors that are already in the (sadly opaque) chacha20.blb file.

Unfortunately there's not good tooling for inspecting those files.

Looking at a dump in xxd, possibly not?

@seanybaggins
Copy link
Author

I fail to see the text vectors using hexdump and grepping for the first 2 bytes of the plain text.

hexdump -x chacha20.blb | awk '{$1=""}1' | tr -d " \t\n\r" | rg 4c61

@tarcieri
Copy link
Member

Curious how the RFC7539 vectors compare to the RFC8439 test vectors: https://datatracker.ietf.org/doc/html/rfc8439#appendix-A

I can look a bit more in depth later.

@seanybaggins
Copy link
Author

So I have looked into the differences between rfc7539 and rfc8439. It looks that these two tests are exactly the same. I will change the name of the test to reflect the more up to date rfc.

@tarcieri
Copy link
Member

As it were, someone else opened #245 to add the RFC 8439 test vectors 😅

Now I need to go through the .blb file and reconcile which vectors are already in there and which ones were missing, as at least upon first glance there are some missing but they're very hard to inspect and have no comments.

@tarcieri
Copy link
Member

Closing in favor of #245 which uses the RFC 8439 test vectors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants