aead: split Aead(Mut) from Aead(Mut)InPlace (fixes #70) #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarcieri
force-pushed
the
aead/split-in-place-api
branch
from
d8cf495
to
d5e45d4
Compare
Splits the `Aead` and `AeadMut` trait into the following: - `Aead` and `AeadMut`:gated on the `alloc` feature - `AeadInPlace` and `AeadMutInPlace`: object-safe, always available This further has the benefit that implementors who don't want to provide or abstract over the in-place APIs no longer have to. To make the `*InPlace` traits object safe, the one generic parameter they previously used (`impl Buffer`) was switched to `dyn Buffer`. This adds some vtable dispatch overhead for manipulating the buffer, but hopefully it is still cheap compared to the overhead of cryptographic operations on the underlying data. That said, no benchmarks have been performed (yet) on the costs of this change.
tarcieri
force-pushed
the
aead/split-in-place-api
branch
from
d5e45d4
to
20f8698
Compare
|
Going to go ahead and merge this, but if anyone has any feedback on it, I'd certainly be interested in hearing it and am happy to do some follow-up passes to revise. |
|
I suppose rust-lang/rfcs#2930 could influence the direction this takes in future. Also maybe rust-lang/rfcs#2895 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splits the
AeadandAeadMuttrait into the following:AeadandAeadMut:gated on theallocfeatureAeadInPlaceandAeadMutInPlace: object-safe, always availableThis further has the benefit that implementors who don't want to provide or abstract over the in-place APIs no longer have to. See
ursaas a real world example of where this split is useful.To make the
*InPlacetraits object safe, the one generic parameter they previously used (impl Buffer) was switched todyn Buffer. This adds some vtable dispatch overhead for manipulating the buffer, but hopefully it is still cheap compared to the overhead of cryptographic operations on the underlying data. That said, no benchmarks have been performed (yet) on the costs of this change.