Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename block-cipher-trait => block-cipher #139

Merged
merged 1 commit into from
May 26, 2020

Conversation

tarcieri
Copy link
Member

This is more consistent with the other RustCrypto/traits crates, as well as shorter and more convenient.

This is more consistent with the other RustCrypto/traits crates, as well
as shorter and more convenient.
@tarcieri tarcieri merged commit 0af4518 into master May 26, 2020
@tarcieri tarcieri deleted the rename-block-cipher-trait-crate branch May 26, 2020 19:25
@tarcieri tarcieri mentioned this pull request Jun 4, 2020
@pheki
Copy link

pheki commented Jun 10, 2020

While this name is better, can you also release 0.7 for block-cipher-trait, probably with a deprecation notice on the crates.io page?

Anyone looking at crates.io (did it myself) or using automated dependency checking won't realize that they're using an outdated dependency.

@tarcieri
Copy link
Member Author

tarcieri commented Jun 10, 2020

Not sure that makes sense. However, I can file an unmaintained crate advisory to RustSec to inform people of the new name.

EDIT: I suppose we could publish a "stub crate" announcing the new name, with no functionality.

@newpavlov
Copy link
Member

I think it's worth to publish an empty v0.7.0 version with deprecation notices.

@tarcieri
Copy link
Member Author

Ok, will do.

@newpavlov
Copy link
Member

Already done. :)

tarcieri added a commit to rustsec/advisory-db that referenced this pull request Jun 10, 2020
tarcieri added a commit to rustsec/advisory-db that referenced this pull request Jun 10, 2020
…0-0018) (#310)

* Add unmaintained crate advisory for `block-cipher-trait`

It's been renamed to `block-cipher`. See:

RustCrypto/traits#139

* Assign RUSTSEC-2020-0018 to block-cipher-trait
@pheki
Copy link

pheki commented Jun 10, 2020

Thanks!

This was referenced Jun 11, 2020
dns2utf8 pushed a commit to dns2utf8/traits that referenced this pull request Jan 24, 2023
This makes the SaltString::generate function available.

Related: RustCrypto#130
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants