-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cipher: rename BlockCipher*
/BlockMode*
#1482
Conversation
Renames the following traits: - `BlockEncrypt` => `BlockCipherEncrypt` - `BlockDecrypt` => `BlockCipherDecrypt` - `BlockEncryptMut` => `BlockModeEncrypt` - `BlockDecryptMut` => `BlockModeDecrypt` As originally suggested in this comment: RustCrypto/block-modes#14 (comment) This better reflects how these traits are actually used, i.e. `BlockCipher*` is used by ciphers, and `BlockMode*` is used by their modes of operation.
BlockCipher*
/BlockMode*
BlockCipher*
/BlockMode*
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it's worth to remove the _mut
suffixes from BlockMode*
method names? It may cause issues when both BlockMode*
and BlockCipher*
imported simultaneously, but I think it's a relatively rare situation in user code.
Hmm, guess I should've prepared a branch of https://github.com/rustcrypto/block-ciphers first because this is causing all sorts of wacky breakages including macro invocation failures like:
|
The branch was never tested against the block ciphers repo located at https://github.com/rustcrypto/block-ciphers There were various errors and missed changes in macros which were required to get everything to compile. This includes fixes and has been tested against the downstream repo.
#1483 contains fixes to errors/omissions in this PR |
The branch was never tested against the block ciphers repo located at https://github.com/rustcrypto/block-ciphers There were various errors and missed changes in macros which were required to get everything to compile. This includes fixes and has been tested against the downstream repo.
Updates the previous `BlockEncrypt`/`BlockEncrypt` trait names to use the new ones introduced in RustCrypto/traits#1482
Updates the previous `BlockEncrypt`/`BlockEncrypt` trait names to use the new ones introduced in RustCrypto/traits#1482
Renames the following traits:
BlockEncrypt
=>BlockCipherEncrypt
BlockDecrypt
=>BlockCipherDecrypt
BlockEncryptMut
=>BlockModeEncrypt
BlockDecryptMut
=>BlockModeDecrypt
As originally suggested in this comment:
RustCrypto/block-modes#14 (comment)
This better reflects how these traits are actually used, i.e.
BlockCipher*
is used by ciphers, andBlockMode*
is used by their modes of operation.