Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename finalize_box to finalize_boxed #182

Merged
merged 1 commit into from
Jun 9, 2020
Merged

Conversation

newpavlov
Copy link
Member

No description provided.

@newpavlov newpavlov merged commit b1d81ba into master Jun 9, 2020
@newpavlov newpavlov deleted the newpavlov-patch-1 branch June 9, 2020 17:59
@tarcieri tarcieri mentioned this pull request Jun 10, 2020
dns2utf8 pushed a commit to dns2utf8/traits that referenced this pull request Jan 24, 2023
…ustCrypto#182)

Closes RustCrypto#179.

This commit makes the `Params` struct always available regardless of
enabled crate features, adding on functionality when the `password-hash`
feature is enabled.

Per the added TODOs in this commit, it really seems like in the next
breaking release, `Argon2::new` should accept `Params` as an argument
rather than duplicating all of the individual parameter fields and
passing them in as arguments. After that, they can be validated and
stored within the `Argon2` struct itself. But that would be a breaking
change, so for now they're stored piecemeal.

Additionally, this commit now ensures enough context is available in the
`Argon2` struct in order to implement `hash_password_simple` that uses
the configured params rather than the defaults, which addresses the
aforementioned issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant