elliptic-curve: remove BitView re-export #540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes the re-export of `ff::BitView`, as the `ff` crate itself is already re-exported, so it's available as `elliptic_curve::ff::BitView`. Note that this is technically a breaking change, however the plan is to release a v0.9.1 and yank the v0.9.0 release. This is acceptable largely because the previous release is not being widely used (released 18 hours ago with 189 downloads) and therefore this change is unlikely to cause problems in practice, especially considering its relatively minor nature.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the re-export of
ff::BitView, as theffcrate itself is already re-exported, so it's available aselliptic_curve::ff::BitView.Note that this is technically a breaking change, however the plan is to release a v0.9.1 and yank the v0.9.0 release. This is acceptable largely because the previous release is not being widely used (released 18 hours ago with 189 downloads) and therefore this change is unlikely to cause problems in practice, especially considering its relatively minor nature.