Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elliptic-curve: non_zero => nonzero #828

Merged
merged 1 commit into from
Dec 3, 2021

Conversation

tarcieri
Copy link
Member

@tarcieri tarcieri commented Dec 3, 2021

In #827, a ReduceNonZero trait was added whose method name uses an underscored *_non_zero.

However, there's already one bit of precedent in the public API:

  • SecretKey::to_nonzero_scalar

Since this is already a stable API and providing precedent, for consistency this commit changes all of the unstable/unreleased APIs and internal module naming to use nonzero instead of non_zero, as this is a non-breaking change.

In #827, a `ReduceNonZero` trait was added whose method name uses an
underscored `*_non_zero`.

However, there's already one bit of precedent in the public API:

- `SecretKey::to_nonzero_scalar`

Since this is already a stable API and providing precedent, for
consistency this commit changes all of the unstable/unreleased APIs and
internal module naming to use `nonzero` instead of `non_zero`, as this
is a non-breaking change.
@tarcieri tarcieri merged commit a01885d into master Dec 3, 2021
@tarcieri tarcieri deleted the elliptic-curve/dehyphenate-nonzero branch December 3, 2021 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant