Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cipher: rename BlockDecryptMut::decrypt_padded_vec to decrypt_padded_vec_mut #941

Merged
merged 1 commit into from
Feb 16, 2022

Conversation

newpavlov
Copy link
Member

It's a breaking change, but the method was introduced in today's release, so hopefully it will not affect anyone. I plan to yank cipher v0.4.1 to prevent further confusion.

@newpavlov newpavlov merged commit 7c24337 into master Feb 16, 2022
@newpavlov newpavlov deleted the cipher/fix_name branch February 16, 2022 15:31
@jcaesar
Copy link

jcaesar commented Feb 17, 2022

You've managed to affect a crate and it's bitten someone. I'm not complaining, I'm just amazed.

I'll throw a PR to p12.

@newpavlov
Copy link
Member Author

Oh, wow... Well, this is unfortunate. @Keruspe has submitted #936 to be used in p12, so no wonders it was used right away after cipher v0.4.1 was released. Unfortunately, it looks like he was offline when I wrote about the fix release.

@jcaesar
Copy link

jcaesar commented Feb 17, 2022

Ah. And here I was wondering how that new function made it into other code so quickly. (Btw, the asker on Stackoverflow isn't exactly following best practice, and not using a lock file.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants