cpufeatures: fix Linux/aarch64 support #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `__detect_target_features` macro was expanding into code that directly referenced `libc::getauxval`. This commit adds a small helper function for querying `AT_HWCAP` using `getauxval` similar to the `sysctlbyname` helper function used on MacOS, and then has the macro invoke it using `$crate::`.
tarcieri
added a commit
that referenced
this pull request
May 6, 2021
As in #398, the `libc` symbol is still being emitted from a macro, in this case to reference the individual hwcaps. This commit re-exports them all from the `cpufeatures::aarch64` module and has the macro reference them that way.
tarcieri
added a commit
that referenced
this pull request
May 6, 2021
As in #398, the `libc` symbol is still being emitted from a macro, in this case to reference the individual hwcaps. This commit re-exports them all from the `cpufeatures::aarch64` module and has the macro reference them that way.
tarcieri
added a commit
that referenced
this pull request
May 6, 2021
As in #398, the `libc` symbol is still being emitted from a macro, in this case to reference the individual hwcaps. This commit re-exports them all from the `cpufeatures::aarch64` module and has the macro reference them that way.
tarcieri
added a commit
that referenced
this pull request
May 6, 2021
As in #398, the `libc` symbol is still being emitted from a macro, in this case to reference the individual hwcaps. This commit re-exports them all from the `cpufeatures::aarch64` module and has the macro reference them that way.
tarcieri
added a commit
that referenced
this pull request
May 6, 2021
As in #398, the `libc` symbol is still being emitted from a macro, in this case to reference the individual hwcaps. This commit re-exports them all from the `cpufeatures::aarch64` module and has the macro reference them that way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
__detect_target_featuresmacro was expanding into code that directly referencedlibc::getauxval.This commit adds a small helper function for querying
AT_HWCAPusinggetauxvalsimilar to thesysctlbynamehelper function used on MacOS, and then has the macro invoke it using$crate::.