cpufeatures: Add support for AArch64 Android (essentially a Linux variant) #752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrose-signal
force-pushed
the
aarch64-android
branch
from
2d52f35
to
4ac7988
Compare
tarcieri
reviewed
Mar 18, 2022
jrose-signal
force-pushed
the
aarch64-android
branch
from
4ac7988
to
bac1b48
Compare
Merged
(Just checking in that I did, in fact, get to this, and it does work.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checking against google/cpu_features it looks like Android follows Linux exactly in how it defines
getauxval, so it really is just turning it on in aarch64.rs.I have not actually tried running this on a 64-bit Android device yet; I'll get to that a bit later today. (Have to get that development environment set up again.) It does pass
cargo build --target aarch64-linux-android, though (unsurprisingly).Fixes #751.