add optimzie-rust-comptime #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Folyd
reviewed
Feb 19, 2023
Folyd
approved these changes
Feb 19, 2023
mfrw
reviewed
Feb 19, 2023
Co-authored-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
LCrossman
reviewed
Feb 22, 2023
| @@ -0,0 +1,200 @@ | |||
|
|
|||
| Although there are often complaints saying Rust'compilation speed is notorious slow, our project [RisingWave](https://github.com/risingwavelabs/risingwave) is not very slow to compile, especially since previously contributors like ([skyzh](https://github.com/skyzh), [BugenZhao](https://github.com/bugenzhao)) have put in a lot of effort. After using an M1 MacBook Pro, compiling is not a problem at all. A full debug compilation only takes 2-3 minutes. | |||
There was a problem hiding this comment.
Just a tiny couple of things - Can we change notorious to notoriously ?
And "is not very slow to compile" to "is not so slow to compile"
There was a problem hiding this comment.
Thanks. You can edit that directly?
There was a problem hiding this comment.
Do I need to revert it? I can only view it at the moment @xxchan
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.