You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is this issue related with the sslError format made by fn convert_openssl_error() ?
I found that RustPython's sslError format is different with CPython's.
RustPython
ssl.SSLError: [Errno 136] [x509 certificate routines] no certificate or crl found (ssl.rs:691)
CPython
ssl.SSLError: [X509: NO_CERTIFICATE_OR_CRL_FOUND] no certificate or crl found (_ssl.c:4293)
CPython is printing lib name : X509 and reason name : NO_CERTIFICATE_OR_CRL_FOUND.
RustPython is printing errCode : [Errno 136] and lib str : [x509 certificate routines].
and errStr : no certificate or crl found is same
CPython is using _ssl_data.h to get the lib name and reason name.
The issue is not about messages but absense of the attribute reason.
In CPython, fill_and_set_sslerror function adds reason attribute, while RustPython doesn't do in convert_openssl_error.
Maybe having same messages would be better, but we don't count them as incompatibility.
Feature
ssl.SSLError.reason
Python Documentation
https://docs.python.org/3/library/ssl.html#ssl.SSLError.reason
The text was updated successfully, but these errors were encountered: