Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 'library', 'reason' Attribute to ssl.SSLError #4058

Merged
merged 1 commit into from
Aug 15, 2022
Merged

Add 'library', 'reason' Attribute to ssl.SSLError #4058

merged 1 commit into from
Aug 15, 2022

Conversation

tgsong827
Copy link
Contributor

This PR associated with #4000.

I added libaray and reason attribute to ssl.SSLError like CPython.

@youknowone youknowone added the z-ca-2022 Tag to track contrubution-academy 2022 label Aug 13, 2022
youknowone
youknowone approved these changes Aug 15, 2022
View reviewed changes
Copy link
Member

@youknowone youknowone left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I had a case triggering this problem, but couldn't find one.
But looks good to work perfect.

@youknowone youknowone merged commit 50aa730 into RustPython:main Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youknowone youknowone youknowone approved these changes

Assignees
No one assigned
Labels
z-ca-2022 Tag to track contrubution-academy 2022
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tgsong827 @youknowone