Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add json output for CPython tests #1834

Merged
merged 7 commits into from
Apr 4, 2020
Merged

Conversation

coolreader18
Copy link
Member

Related to #1671

@ep12
Copy link

ep12 commented Apr 3, 2020

See #1838 (example section):
This pr implements the code object co_varnames attribute, but the value differs from the ones cpython and pypy present...

@abitrolly
Copy link

Does it produce the result in real-time, or only after the processing is finished?

Is it a custom format, or something like https://chromium.googlesource.com/chromium/src.git/+/master/docs/testing/json_test_results_format.md was used for an inspiration?

@coolreader18
Copy link
Member Author

coolreader18 commented Apr 3, 2020

@abitrolly I'm not sure what you mean by your first question, but as to your second I think it's basically just the data that unittest outputs itself, converted to JSON. I didn't write the runner myself, I modified it from https://github.com/agramian/custom-text-test-runner, so I can't say for certain.

@coolreader18 coolreader18 merged commit f5de59a into master Apr 4, 2020
@coolreader18
Copy link
Member Author

@ep12 I'll look into fixing co_varnames separately.

@coolreader18 coolreader18 deleted the coolreader18/jsontests branch April 11, 2020 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants