Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update ioctl first arg #4140

Merged
merged 3 commits into from
Aug 30, 2022
Merged

update ioctl first arg #4140

merged 3 commits into from
Aug 30, 2022

Conversation

tgsong827
Copy link
Contributor

@tgsong827 tgsong827 commented Aug 29, 2022

#4070

  • add test_ioctl.py.
  • update fn ioctl can take others having fileno method not only Integer.

Copy link
Member

@youknowone youknowone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rust code changes are looking good.

Comment on lines +69 to +70
# TODO: RUSTPYTHON
@unittest.expectedFailure
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We usually create a separated commit for cpython libraries and commits. Please create commits again like this: https://github.com/RustPython/RustPython/pull/4029/commits

@youknowone youknowone added the z-ca-2022 Tag to track contrubution-academy 2022 label Aug 29, 2022
Copy link
Member

@youknowone youknowone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@youknowone youknowone merged commit 8001ff8 into RustPython:main Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
z-ca-2022 Tag to track contrubution-academy 2022
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants