Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update test/test_types from CPython 3.11.2 #4683

Merged
merged 4 commits into from
Mar 12, 2023
Merged

Update test/test_types from CPython 3.11.2 #4683

merged 4 commits into from
Mar 12, 2023

Conversation

tdub0
Copy link
Contributor

@tdub0 tdub0 commented Mar 12, 2023

#4564
Changes from CPython v3.11.2 produce a single failure on a new test test_dunder_get_signature. There seems to be no signature found in builtin method __get__ of 'method_descriptor' objects, so it raises a ValueError. I added the expectedFailure decorator to that function.

DimitrisJim
DimitrisJim reviewed Mar 12, 2023
View reviewed changes
Lib/test/test_types.py Outdated Show resolved Hide resolved
DimitrisJim
DimitrisJim approved these changes Mar 12, 2023
View reviewed changes
Copy link
Member

@DimitrisJim DimitrisJim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this!

@DimitrisJim DimitrisJim mentioned this pull request Mar 12, 2023
Closed
@DimitrisJim DimitrisJim merged commit f583f9a into RustPython:main Mar 12, 2023
@tdub0 tdub0 deleted the test_types_modify branch March 12, 2023 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DimitrisJim DimitrisJim DimitrisJim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tdub0 @DimitrisJim