Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update test_builtin.py from cpython v3.11.2 #4765

Merged
merged 4 commits into from
Mar 25, 2023
Merged

update test_builtin.py from cpython v3.11.2 #4765

merged 4 commits into from
Mar 25, 2023

Conversation

JaeyoungAhn
Copy link
Contributor

#4564 update test_builtin.py from cpython v3.11.2

@DimitrisJim
Copy link
Member

thanks! There's some additional regressions here which should be noted: test_delattr, test_getattr, test_hasattr and test_setattr should probably all be related. test_type_name is also failing now.

@DimitrisJim DimitrisJim mentioned this pull request Mar 25, 2023
Closed
DimitrisJim
DimitrisJim approved these changes Mar 25, 2023
View reviewed changes
Copy link
Member

@DimitrisJim DimitrisJim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hopefully should be good to go now.

@DimitrisJim DimitrisJim merged commit cfed9f3 into RustPython:main Mar 25, 2023
@youknowone youknowone added A-design About RustPython's own implementation z-ca-2023 Tag to track contrubution-academy 2023 labels Mar 25, 2023
youknowone
youknowone reviewed Mar 25, 2023
View reviewed changes
Lib/test/test_builtin.py
@@ -94,7 +94,7 @@ def write(self, line):
('', ValueError),
(' ', ValueError),
(' \t\t ', ValueError),
# (str(br'\u0663\u0661\u0664 ','raw-unicode-escape'), 314), XXX RustPython
(str(br'\u0663\u0661\u0664 ','raw-unicode-escape'), 314),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Lib/test/test_builtin.py
@@ -1475,11 +1614,16 @@ def test_bug_27936(self):
self.assertEqual(round(x, None), round(x))
self.assertEqual(type(round(x, None)), type(round(x)))

# TODO: RUSTPYTHON
@unittest.expectedFailure
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixing this one is looking like a good first issue

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DimitrisJim I believe this should have been broken out into a separate commit.

@youknowone youknowone added A-stdlib and removed A-design About RustPython's own implementation labels Mar 25, 2023
fanninpm
fanninpm reviewed Mar 25, 2023
View reviewed changes
Lib/test/test_builtin.py
Comment on lines +526 to +527
# TODO: RUSTPYTHON
@unittest.expectedFailure
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DimitrisJim I believe this should have been broken out into a separate commit.

fanninpm
fanninpm reviewed Mar 25, 2023
View reviewed changes
Lib/test/test_builtin.py
Comment on lines +760 to +761
# TODO: RUSTPYTHON
@unittest.expectedFailure
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DimitrisJim I believe this should have been broken out into a separate commit.

fanninpm
fanninpm reviewed Mar 25, 2023
View reviewed changes
Lib/test/test_builtin.py
Comment on lines +794 to +795
# TODO: RUSTPYTHON
@unittest.expectedFailure
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DimitrisJim I believe this should have been broken out into a separate commit.

fanninpm
fanninpm reviewed Mar 25, 2023
View reviewed changes
Lib/test/test_builtin.py
Comment on lines +815 to +816
# TODO: RUSTPYTHON
@unittest.expectedFailure
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DimitrisJim I believe this should have been broken out into a separate commit.

fanninpm
fanninpm reviewed Mar 25, 2023
View reviewed changes
Lib/test/test_builtin.py
Comment on lines +839 to +840
# TODO: RUSTPYTHON
@unittest.expectedFailure
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DimitrisJim I believe this should have been broken out into a separate commit.

fanninpm
fanninpm reviewed Mar 25, 2023
View reviewed changes
Lib/test/test_builtin.py
Comment on lines +950 to +951
# TODO: RUSTPYTHON
@unittest.expectedFailure
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DimitrisJim I believe this should have been broken out into a separate commit.

fanninpm
fanninpm reviewed Mar 25, 2023
View reviewed changes
Lib/test/test_builtin.py
Comment on lines +963 to +964
# TODO: RUSTPYTHON
@unittest.expectedFailure
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DimitrisJim I believe this should have been broken out into a separate commit.

fanninpm
fanninpm reviewed Mar 25, 2023
View reviewed changes
Lib/test/test_builtin.py
Comment on lines +2413 to +2414
# TODO: RUSTPYTHON
@unittest.expectedFailure
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DimitrisJim I believe this should have been broken out into a separate commit.

@DimitrisJim DimitrisJim mentioned this pull request Mar 27, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youknowone youknowone youknowone left review comments

@fanninpm fanninpm fanninpm left review comments

@DimitrisJim DimitrisJim DimitrisJim approved these changes

Assignees
No one assigned
Labels
A-stdlib z-ca-2023 Tag to track contrubution-academy 2023
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@JaeyoungAhn @DimitrisJim @youknowone @fanninpm